Changing user/me route to include all home info #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adhi0331
requested changes
Oct 22, 2023
| mentorUniversity: mentor?.college ?? "N/A", | ||
| mentorCareer: mentor?.career ?? "N/A", | ||
| upcomingSessionId: upcomingSessionId ?? "N/A", | ||
| pastSessionId: pastSessionId ?? "N/A", |
There was a problem hiding this comment.
I think it's good that we're returning both the upcoming session id and past session id. I was just wondering if in the session document we store some field to state whether a session was canceled or rescheduled. I only ask because on Frontend we have to update the session card based on whether a session is scheduled, canceled, or rescheduled for the mentee home page. If you think that we can implement that feature on the Home Page with the current route as it stands then I think its good to merge. Otherwise, it might be useful to look into changing the sessions route to reflect whether a session was canceled, rescheduled, or no changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking Info
Resolves #163
Changes
What changes did you make?
Added a new route (user/me) to get all of the necessary info for the user's home page.
Testing
How did you confirm your changes worked?
I used postman to ensure that the route was working for both a mentor and mentee user.
Confirmation of Change
Upload a screenshot, if possible. Otherwise, please provide instructions on how to see the change.
Mentor:
Mentee:
