TOOLS-xxxx use more content-type: in manta uploads #1063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bahamat
requested changes
Nov 21, 2022
| @@ -133,7 +162,9 @@ function upload | |||
| verbose mmkdir -p "$mbdir" | |||
|
|
|||
| for file in $bits_dir/*; do | |||
| verbose mput -f "$file" "$mbdir/$(basename $file)" | |||
| filename="$(basename $file)" | |||
| verbose mput -H "$(content_type $filename)" -f "$file" \ | |||
There was a problem hiding this comment.
This needs to be:
-H "content-type: $(content_type $filename)"
There was a problem hiding this comment.
Oh, wait...you're already including the header name. That should work. I guess we'll need to dig into Jenkins to see what went wrong.
There was a problem hiding this comment.
I think it's TritonDataCenter/eng that needs some changes here too. Building one right now that I hope will include the content-type branch of eng.
There was a problem hiding this comment.
In the "upload-bits" script.
There was a problem hiding this comment.
danmcd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.