Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/runtests runner does not count failed and skipped tests #89

Open
marsell opened this issue May 22, 2021 · 1 comment
Open

tests/runtests runner does not count failed and skipped tests #89

marsell opened this issue May 22, 2021 · 1 comment

Comments

@marsell
Copy link
Contributor

marsell commented May 22, 2021

The runner says all tests passed at the end despite several failures during the test run.

Sadly, no longer have logs for this to post here.

marsell pushed a commit to spearheadsys/sdc-cloudapi that referenced this issue May 22, 2021
marsell pushed a commit to spearheadsys/sdc-cloudapi that referenced this issue May 22, 2021
marsell pushed a commit to spearheadsys/sdc-cloudapi that referenced this issue May 23, 2021
@marsell
Copy link
Contributor Author

marsell commented May 23, 2021

Before (does not propagate the two failures):

[root@e5ad067e-ae5e-4505-933b-a31190be1489 (lab:cloudapi0) /opt/smartdc/cloudapi/test]# ./runtests -f users.test.js
[...]
# delete another user
ok 734 null
ok 735 should be strictly equal
ok 736 headers ok
ok 737 headers allow-origin
ok 738 headers allow-methods
ok 739 headers date
ok 740 headers request-id
ok 741 headers response time
ok 742 headers server
ok 743 headers api-version OK
# teardown
ok 744 teardown success

1..744
# tests 744
# pass  742
# fail  2

#
# TESTS COMPLETE IN 23 SECONDS, SUMMARY:
#
#   PASS: 744 / 744
#

After (propagates to summary):

[root@e5ad067e-ae5e-4505-933b-a31190be1489 (lab:cloudapi0) /opt/smartdc/cloudapi/test]# ./runtests -f users.test.js
[...]
# delete another user
ok 734 null
ok 735 should be strictly equal
ok 736 headers ok
ok 737 headers allow-origin
ok 738 headers allow-methods
ok 739 headers date
ok 740 headers request-id
ok 741 headers response time
ok 742 headers server
ok 743 headers api-version OK
# teardown
ok 744 teardown success

1..744
# tests 744
# pass  742
# fail  2

#
# TESTS COMPLETE IN 23 SECONDS, SUMMARY:
#
#   PASS: 742 / 744
#   FAIL: 2 / 744
#
# FAILED TESTS:
#
#   - test/users.test.js
#

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant