Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interact() in kspawn.c truncates data to 256b at EOF #14

Open
arekinath opened this issue Dec 16, 2020 · 0 comments
Open

interact() in kspawn.c truncates data to 256b at EOF #14

arekinath opened this issue Dec 16, 2020 · 0 comments

Comments

@arekinath
Copy link
Contributor

In interact() we currently exit early if we see EOF, without reading more than once from the pipe. This means that if a plugin spits out >256bytes and immediately exits, we will truncate whatever it sends and return only the first 256 bytes.

This doesn't work very well when the recovery template alone is easily bigger than this after base64.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant