Use 'python3' to access Python #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlettroscoe
requested changes
Jun 7, 2024
There was a problem hiding this comment.
There were a couple of replacements of python3 with python33. We should fix those before merging?
P.S. Clearly string-replace.py and token-replace.py don't have automated tests in TriBITS or the full TriBITS test suite would not have passed using the GHA builds. But those are tiny little utilities that are easy to check the results after they run, so those might just meet the criteria for not needing tests as per When NOT to Write Automated Tests?.
refactoring/string-replace.py
Outdated
| @@ -1,4 +1,4 @@ | |||
| #!/bin/env python3 | |||
| #!/bin/env python33 | |||
There was a problem hiding this comment.
This should be 'python3', no?
refactoring/token-replace.py
Outdated
| @@ -1,4 +1,4 @@ | |||
| #!/bin/env python3 | |||
| #!/bin/env python33 | |||
There was a problem hiding this comment.
Again, this should be python3.
bartlettroscoe
force-pushed
the
python3
branch
2 times, most recently
from
bc0e571
to
eb270d5
Compare
As per https://peps.python.org/pep-0394, it is best practice to not use 'python' in shebangs. Use the explicit `python3` entry point instead. Signed-off-by: Samuel E. Browne <[email protected]>
Signed-off-by: Samuel E. Browne <[email protected]>
bartlettroscoe
force-pushed
the
python3
branch
from
eb270d5
to
3dca096
Compare
bartlettroscoe
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
I rebased the commits and remove the changes to the refactoring/ scripts that changed python3 to python33.
This goes well with the recent PRs:
- Transition to find_package(Python3) (#610) #616
- Fixup for change to find_package(Python3) (#610) #617
and think think this resolves #610.
Thanks @sebrowne!
bartlettroscoe
added a commit
to trilinos/Trilinos
that referenced
this pull request
Oct 10, 2024
Origin repo remote tracking branch: 'github/master' Origin repo remote repo URL: 'github = [email protected]:TriBITSPub/TriBITS.git' Git describe: tribits_start-3502-g28a36351 At commit: commit 3dca096437acbb7a16b88bee7d9569bccd8e6317 Author: Samuel E. Browne <[email protected]> Date: Thu Jun 6 15:26:15 2024 -0600 Summary: Add Python3 requirement to user guide (#610) Mostly, this was done to brings in the changes for transitioning to find_package(Python3) (see TriBITSPub/TriBITS#610). But the full set of TriBITS PRs merged in were: * TriBITSPub/TriBITS#608 sebrowne/python3 * TriBITSPub/TriBITS#617 TriBITSPub/610-python3-2 * TriBITSPub/TriBITS#616 bartlettroscoe/610-python3 * TriBITSPub/TriBITS#615 bartlettroscoe/enable-disable-doc-update-2024-08-29 * TriBITSPub/TriBITS#611 bartlettroscoe/tril-13133-TriBITS-Update-License-and-Copyright-2 * TriBITSPub/TriBITS#614 bartlettroscoe/tribits-updates-2024-08-01 * TriBITSPub/TriBITS#613 TriBITSPub/612-improve-tribits-version-error * TriBITSPub/TriBITS#609 bartlettroscoe/tril-13133-TriBITS-Update-License-and-Copyright
bartlettroscoe
added a commit
to bartlettroscoe/Trilinos
that referenced
this pull request
Oct 11, 2024
Origin repo remote tracking branch: 'github/master' Origin repo remote repo URL: 'github = [email protected]:TriBITSPub/TriBITS.git' Git describe: tribits_start-3502-g28a36351 At commit: commit 3dca096437acbb7a16b88bee7d9569bccd8e6317 Author: Samuel E. Browne <[email protected]> Date: Thu Jun 6 15:26:15 2024 -0600 Summary: Add Python3 requirement to user guide (trilinos#610) Mostly, this was done to brings in the changes for transitioning to find_package(Python3) (see TriBITSPub/TriBITS#610). But the full set of TriBITS PRs merged in were: * TriBITSPub/TriBITS#608 sebrowne/python3 * TriBITSPub/TriBITS#617 TriBITSPub/610-python3-2 * TriBITSPub/TriBITS#616 bartlettroscoe/610-python3 * TriBITSPub/TriBITS#615 bartlettroscoe/enable-disable-doc-update-2024-08-29 * TriBITSPub/TriBITS#611 bartlettroscoe/tril-13133-TriBITS-Update-License-and-Copyright-2 * TriBITSPub/TriBITS#614 bartlettroscoe/tribits-updates-2024-08-01 * TriBITSPub/TriBITS#613 TriBITSPub/612-improve-tribits-version-error * TriBITSPub/TriBITS#609 bartlettroscoe/tril-13133-TriBITS-Update-License-and-Copyright Signed-off-by: Roscoe A. Bartlett <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per https://peps.python.org/pep-0394, it is best practice to not use
pythonin shebangs. Use the explicitpython3entry point instead.Closes #607
I did not test this manually, I was planning on seeing how it works within the automated tests.
This is technically a break in backwards compatibility, but may not be experienced given how long Python 2 has been out of support.