Merge pull request #35 from Trendyol/slidable_content_scale_problems

fix slidable content scale & height problems
Trendyol · Jun 13, 2024 · cd51eea · cd51eea
2 parents 66a4cf8 + c2eddf4
commit cd51eea
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/library/src/main/java/com/trendyol/showcase/ui/slidablecontent/SlidableContentAdapter.kt b/library/src/main/java/com/trendyol/showcase/ui/slidablecontent/SlidableContentAdapter.kt
@@ -8,6 +8,7 @@ import androidx.recyclerview.widget.RecyclerView
 import com.trendyol.showcase.databinding.ItemSlidableContentBinding
 import com.trendyol.showcase.ui.loadImage
 import com.trendyol.showcase.ui.setTextSizeInSp
+import com.trendyol.showcase.util.getHeightInPixels
 
 internal class SlidableContentAdapter(private val slidableContentList: List<SlidableContent>) :
     RecyclerView.Adapter<SlidableContentAdapter.ViewPagerViewHolder>() {
@@ -57,9 +58,14 @@ internal class SlidableContentAdapter(private val slidableContentList: List<Slid
                     isVisible = viewState.isDescriptionVisible()
                     setTextSizeInSp(viewState.slidableContent.descriptionTextSize)
                 }
-
+                imageView.layoutParams.height =
+                    binding.root.context.resources.getHeightInPixels() / SLIDABLE_IMAGE_HEIGHT_RATIO
                 imageView.loadImage(viewState.slidableContent.imageUrl)
             }
         }
     }
+
+    companion object {
+        private const val SLIDABLE_IMAGE_HEIGHT_RATIO = 5
+    }
 }
diff --git a/library/src/main/res/layout/item_slidable_content.xml b/library/src/main/res/layout/item_slidable_content.xml
@@ -8,8 +8,9 @@
     <androidx.appcompat.widget.AppCompatImageView
         android:id="@+id/imageView"
         android:layout_width="0dp"
-        android:layout_height="140dp"
-        android:scaleType="centerCrop"
+        android:layout_height="wrap_content"
+        android:adjustViewBounds="true"
+        android:scaleType="fitXY"
         app:layout_constraintEnd_toEndOf="parent"
         app:layout_constraintStart_toStartOf="parent"
         app:layout_constraintTop_toTopOf="parent" />