Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: extract listener method #23

Open
oguzyildirim opened this issue Mar 15, 2023 · 0 comments
Open

chore: extract listener method #23

oguzyildirim opened this issue Mar 15, 2023 · 0 comments
Labels
good first issue Good for newcomers

Comments

@oguzyildirim
Copy link
Member

We can extract the listener [^1] method and divide it into two. One method may create couchbase events 1 and one method uses a mapper and produce events 2.

[^1] : https://github.com/Trendyol/go-kafka-connect-couchbase/blob/master/connector.go#L42

Footnotes

  1. https://github.com/Trendyol/go-kafka-connect-couchbase/blob/master/connector.go#L43 ↩

  2. https://github.com/Trendyol/go-kafka-connect-couchbase/blob/master/connector.go#L55 ↩
@oguzyildirim oguzyildirim added the good first issue Good for newcomers label Apr 18, 2023
@oguzyildirim oguzyildirim reopened this Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@oguzyildirim