Synth.onsilence is unreliable at scale

[mildfuzz]

I have managed to contrive a reproduction.

We have an arbitrary synth buffer (50). Once that is full no more will be created

After 10 seconds, the remaining buffers (that didn't get disposed of) are logged to console. We expect zero, but we usually get over 30.

This is causing memory leaks in my real world app as synths are not cleaning up after themselves

https://codesandbox.io/p/sandbox/synth-onsilence-forked-xygrhy?workspaceId=6877f6b3-5e2a-423a-a4c1-5b098cab00e5

[mildfuzz]

for now, I am able to work around it by deducing note time, adding a slight buffer, and using setTimeout

synth.triggerAttackRelease(this.sounds.nextNote, '16n')

    const totalSynthTimeMS = (Tone.Time('16n').toSeconds() + 0.1) * 1000

    setTimeout(
      ((s: Tone.FMSynth) => {
        this.synths.delete(synth)
        s.dispose()
      }).bind(this, synth),
      totalSynthTimeMS,
    )

But this might be harder to manage when I have lots of instrument types