From 2ebba8ab146e3db821983d5bb3702db5b7b54445 Mon Sep 17 00:00:00 2001
From: Tomas Votruba <tomas.vot@gmail.com>
Date: Tue, 3 Dec 2024 15:45:33 +0100
Subject: [PATCH] misc

---
 src/Reporting/UnusedClassReporter.php | 27 ++++++++++++++-------------
 1 file changed, 14 insertions(+), 13 deletions(-)

diff --git a/src/Reporting/UnusedClassReporter.php b/src/Reporting/UnusedClassReporter.php
index 361c9b04..ee96485e 100644
--- a/src/Reporting/UnusedClassReporter.php
+++ b/src/Reporting/UnusedClassReporter.php
@@ -44,28 +44,26 @@ public function reportResult(UnusedClassesResult $unusedClassesResult, bool $isJ
 
         // separate with and without parent, as first one can be removed more easily
         if ($unusedClassesResult->getWithParentsFileWithClasses() !== []) {
-            $this->symfonyStyle->section('Classes with a parent/interface - possibly used by type');
-            $this->reportFileWithClasses($unusedClassesResult->getWithParentsFileWithClasses());
+            $this->printLineWIthClasses(
+                'Classes with a parent/interface',
+                $unusedClassesResult->getWithParentsFileWithClasses()
+            );
         }
 
         if ($unusedClassesResult->getParentLessFileWithClasses() !== []) {
-            $this->symfonyStyle->newLine();
-            $this->symfonyStyle->section('Classes without any parent/interface - easier to remove');
-
-            $this->reportFileWithClasses($unusedClassesResult->getParentLessFileWithClasses());
+            $this->printLineWIthClasses(
+                'Classes without any parent/interface - easier to remove',
+                $unusedClassesResult->getParentLessFileWithClasses()
+            );
         }
 
-        // @todo traits - the easier to remove as hardly used anywhere
         if ($unusedClassesResult->getTraits() !== []) {
-            $this->symfonyStyle->newLine();
-            $this->symfonyStyle->section('Traits without any use - the easiest to remove');
-
-            $this->reportFileWithClasses($unusedClassesResult->getTraits());
+            $this->printLineWIthClasses('Unused traits - the easiest to remove', $unusedClassesResult->getTraits());
         }
 
         $this->symfonyStyle->newLine();
         $this->symfonyStyle->error(sprintf(
-            'Found %d unused classes. Check and remove them or skip them using "--skip-type" option',
+            'Found %d unused classes. Remove them or skip them using "--skip-type" option',
             $unusedClassesResult->getCount()
         ));
 
@@ -75,8 +73,11 @@ public function reportResult(UnusedClassesResult $unusedClassesResult, bool $isJ
     /**
      * @param FileWithClass[] $fileWithClasses
      */
-    private function reportFileWithClasses(array $fileWithClasses): void
+    private function printLineWIthClasses(string $title, array $fileWithClasses): void
     {
+        $this->symfonyStyle->newLine();
+        $this->symfonyStyle->section($title);
+
         foreach ($fileWithClasses as $fileWithClass) {
             $this->symfonyStyle->writeln($fileWithClass->getFilePath());
             $this->symfonyStyle->newLine();