Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resource leaks of the Future-based implementation #71

Closed
TomasMikula opened this issue Apr 24, 2022 · 1 comment
Closed

Fix resource leaks of the Future-based implementation #71

TomasMikula opened this issue Apr 24, 2022 · 1 comment

Comments

@TomasMikula
Copy link
Owner

Fix the resource leak related to long chains of promises (as described in #46) in Future-based implementation.

The problem is likely fixable by adding an extra level of indirection.

Add tests that check that the number of allocated promises remains constant for several use cases. (Depends on #70.)

@TomasMikula
Copy link
Owner Author

On closer look, there might not be a leak in the Future-based implementation. The use of Future#onComplete is scarce, and only in places where either

  • the chain of promises cannot be compacted anyway, or
  • the Future originates from a Promise that is going to be completed promptly, as the use of Promise is just auxiliary during materialization of the program.

@TomasMikula TomasMikula closed this as not planned Won't fix, can't repro, duplicate, stale Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant