Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When deleting files and updating indexes, keep a backup file until the index is updated #264

Open
TinCanTech opened this issue Feb 7, 2022 · 3 comments
Open

When deleting files and updating indexes, keep a backup file until the index is updated #264

TinCanTech opened this issue Feb 7, 2022 · 3 comments
Assignees
@TinCanTech
Labels
Improvement Testing welcome
Milestone
Version 2.8.0

Comments

@TinCanTech
Copy link
Owner

No description provided.

@TinCanTech TinCanTech added this to the Version 2.8.0 (The forth) milestone Feb 7, 2022
@TinCanTech TinCanTech self-assigned this Feb 7, 2022
TinCanTech referenced this issue Feb 8, 2022
@TinCanTech
Resolve "delete-file before update-index" conundrum
1add248 
1. Move the files, to ensure permissions are correct
2. Update index

3a. If Update index success: Remove files
3b. If Update index failure: Restore files

Signed-off-by: Richard T Bonhomme <[email protected]>
TinCanTech referenced this issue Feb 8, 2022
@TinCanTech
[Bug] Remove incorrect else condition
4df3ea4 
Signed-off-by: Richard T Bonhomme <[email protected]>
TinCanTech referenced this issue Feb 8, 2022
@TinCanTech
Resolve "delete-file before update-index" conundrum
6d04cb6 
1. Move the files, to ensure permissions are correct
2. Update index

3a. If Update index success: Remove files
3b. If Update index failure: Restore files

Signed-off-by: Richard T Bonhomme <[email protected]>
@TinCanTech TinCanTech added Solution applied This issue has been solved Testing welcome labels Feb 8, 2022
@TinCanTech
Copy link
Owner Author

This is not completed ..

@TinCanTech
Copy link
Owner Author

Improve inline_share_fingerprint

@TinCanTech TinCanTech reopened this Feb 27, 2022
@TinCanTech TinCanTech removed the Solution applied This issue has been solved label Feb 27, 2022
TinCanTech referenced this issue Feb 28, 2022
@TinCanTech
Allow inline_index_update() 'add' to recover index on failure
a162ff9 
The original inline-index is kept until the update successfully completes.
Otherwise, the original inline-index is put back in place.

Signed-off-by: Richard T Bonhomme <[email protected]>
TinCanTech referenced this issue Feb 28, 2022
@TinCanTech
Allow inline_index_update() 'del' to recover index on failure
26d4677 
The original inline-index is kept until the update successfully completes.
Otherwise, the original inline-index is put back in place.

Signed-off-by: Richard T Bonhomme <[email protected]>
TinCanTech referenced this issue Mar 2, 2022
@TinCanTech
Improvements to save_master_hash() plumbing
9679db3 
* skip_master_hash=1
Introduce secondary layer of protection:
All commands which make no changes MUST use skip_master_hash.
All commands which make changes MUST use update_master_hash.
skip_master_hash and update_master_hash are mutually exclusive.

* Restyle save_master_hash(), minor improvement.

* Add check for empty input list to generate the master hash.

* easytls_create_layout() prints fixed-hashes to default hash-files.

Signed-off-by: Richard T Bonhomme <[email protected]>
TinCanTech referenced this issue Mar 6, 2022
@TinCanTech
Make backup-files prior to changes
eadd16e 
A backup-file 'example.txt.tmp' is created and removed for:
* Config-file updates
* Inline-index updates
* TLSKey-index updates
* Disabled-list updates

Signed-off-by: Richard T Bonhomme <[email protected]>
TinCanTech referenced this issue Mar 7, 2022
@TinCanTech
Introduce universal_update()
6008da1 
Allow updates to config, indexes and lists to use a single function.
Include file protection measures in the one function.

Also make inline_index_update() and tlskey_index_update() use this
function.

Signed-off-by: Richard T Bonhomme <[email protected]>
TinCanTech referenced this issue Mar 7, 2022
@TinCanTech
Make disabled_list_manager() use universal_update()
dcd0c40 
Signed-off-by: Richard T Bonhomme <[email protected]>
TinCanTech referenced this issue Mar 7, 2022
@TinCanTech
Archive disabled_list_update()
13abe14 
Signed-off-by: Richard T Bonhomme <[email protected]>
TinCanTech referenced this issue Mar 8, 2022
@TinCanTech
Make config_update() use universal_update()
b1eaf45 
Signed-off-by: Richard T Bonhomme <[email protected]>
TinCanTech referenced this issue Mar 8, 2022
@TinCanTech
Remove useless file recovery code
10fcbd1 
The code here is all replaced by code within univeral_update()

Signed-off-by: Richard T Bonhomme <[email protected]>
TinCanTech referenced this issue Mar 8, 2022
@TinCanTech
Make remove_inline() only backup the inline-file to be removed
59d057d 
Before, this would also backup the inline-index.

Signed-off-by: Richard T Bonhomme <[email protected]>
TinCanTech referenced this issue Mar 8, 2022
@TinCanTech
Make remove_group_inline() only backup the inline-file to be removed
352f867 
Remove unset -v inline_hash; easy-tls no longer supports inline_renew()

Signed-off-by: Richard T Bonhomme <[email protected]>
@TinCanTech
Copy link
Owner Author

remove_metadata() is still unsafe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TinCanTech TinCanTech

Labels
Improvement Testing welcome
Projects
None yet
Milestone
Version 2.8.0
Development

No branches or pull requests
1 participant
@TinCanTech