Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Hidden Setting: Default Tiddler Colour changes default tag color #8760

Open
amreus opened this issue Nov 18, 2024 · 8 comments
Open

[BUG] Hidden Setting: Default Tiddler Colour changes default tag color #8760

amreus opened this issue Nov 18, 2024 · 8 comments

Comments

@amreus
Copy link

amreus commented Nov 18, 2024

Describe the bug

tiddlywiki.com says:

A default tiddler colour can be specified by creating a tiddler called $:/config/DefaultTiddlerColour containing the CSS color value.

But setting the text of this tiddler to a color changes the default tag color, and not the default tiddler color.

Not sure if documentation issue or code issue.

Expected behavior

No response

To Reproduce

No response

Screenshots

No response

TiddlyWiki Configuration

v5.3.6 at tiddlywiki.com

Additional context

No response

@pmario
Copy link
Member

pmario commented Nov 18, 2024

The code has always been like that. IMO it's a naming and documentation problem. The hidden-setting tiddler should probably link to Tiddler Colour Cascade tiddler for more info

As you can see at: https://tiddlywiki.com/#Tiddler%20Colour%20Cascade all the elements are "tag-related".

@Leilei332
Copy link
Contributor

This is because tag pills uses the tiddler color if it has one, and falls back if there isn't. Setting the default color specifies all the tiddlers' color, which cause tag pills to use the color.

@amreus
Copy link
Author

amreus commented Nov 20, 2024

This is because tag pills uses the tiddler color if it has one, and falls back if there isn't. Setting the default color specifies all the tiddlers' color, which cause tag pills to use the color.

How do you set a tiddler color?

@pmario
Copy link
Member

pmario commented Nov 20, 2024

The term is a bit misleading.

  • If you have a tiddler named eg: aaa and you define a field named: "color: red"
  • Create bbb and tag it aaa -> save
  • The colour of the aaa tag-pill will be red

@amreus
Copy link
Author

amreus commented Nov 20, 2024

So we are talking about using the color field in a tag tiddler which is used to set the color of the tag, but the docs still call this "tiddler color" which might be technically correct for a tag tiddler but does not make sense for any other tiddler; and which might be better stated as "tiddler color field" or "color field of the tag tiddler" or something like that. Documentation would benefit from clarification.

@pmario
Copy link
Member

pmario commented Nov 20, 2024

New PR at: [DOCS] Slightly improve the documentation for tiddler color-field #8765

@Leilei332
Copy link
Contributor

Leilei332 commented Nov 21, 2024

I think the concept of tiddler color isn't clear enough. It is not only used in tag pills, but also used in it's icon's color.

@pmario
Copy link
Member

pmario commented Nov 21, 2024

See: #8770

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants