fix(#12): skip global error handler when there is no errors.

ThoughtWorks-DPS · Mar 8, 2024 · b080a3b · b080a3b
1 parent 3fb3f09
commit b080a3b
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/pkg/handler/error_handler.go b/pkg/handler/error_handler.go
@@ -12,6 +12,10 @@ func ErrorHandler() gin.HandlerFunc {
 	return func(c *gin.Context) {
 		c.Next()
 
+		if len(c.Errors) < 1 {
+			return
+		}
+
 		err := c.Errors[0].Err
 
 		errorResponseBody := NewErrorResponseBody(getErrorCode(err), err.Error())

diff --git a/scripts/namespace.http b/scripts/namespace.http
@@ -26,7 +26,11 @@ GET http://localhost:8080/namespaces HTTP/1.1
 content-type: application/json
 
 ### List namespaces by team ID
-GET http://localhost:8080/namespaces?filters[namespace_team_id]=team-sapphire
+GET http://localhost:8080/namespaces?filters[namespace_team_id]=team-sapphire&filters[namespace_type]=standard
+content-type: application/json
+
+### List namespaces by team ID and standard type
+GET http://localhost:8080/namespaces?filters[namespace_team_id]=team-sapphire&filters[namespace_type]=standard
 content-type: application/json
 
 ### List namespaces by standard type