From 6217ebf2d42e6d9778e6d6d38efb4418ac106e84 Mon Sep 17 00:00:00 2001 From: Thomas Rahm <67757218+ThomasRahm@users.noreply.github.com> Date: Wed, 4 Jan 2023 00:57:47 +0100 Subject: [PATCH] Added comment explaining why a refactor has caused unintentional issues in the past --- src/TreeSupport.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/TreeSupport.cpp b/src/TreeSupport.cpp index 48a1194f02..901eb89407 100644 --- a/src/TreeSupport.cpp +++ b/src/TreeSupport.cpp @@ -229,7 +229,8 @@ std::vector TreeSupport::convertLinesToInternal(Po // NOTE: The volumes below (on which '.inside(p, true)' is called each time below) are the same each time. The values being calculated here are strictly local as well. // So they could in theory be pre-calculated here (outside of the loop). However, when I refatored it to be that way, it seemed to cause deadlocks each time for some settings. - + // NOTE2: When refactoring ensure that avoidance to buildplate is only requested when support_rest_preference == RestPreference::BUILDPLATE as otherwise it has not been precalculated (causing long delays while it is calculated when requested here). + std::vector result; // Also checks if the position is valid, if it is NOT, it deletes that point for (const auto& line : polylines)