Skip to content

Latest commit

 

History

History
56 lines (41 loc) · 2.57 KB

pull_requests.md

File metadata and controls

56 lines (41 loc) · 2.57 KB

Pull Request process

Pull Requests in the openshift-ansible project follow a Continuous Integration process that is similar to the process observed in other repositories such as origin.

Whenever a Pull Request is opened, all automated test jobs must be successfully run before the PR can be merged.

Some of these jobs are automatically triggered, e.g., Travis, PAPR, and Coveralls. Other jobs need to be manually triggered by a member of the Team OpenShift Ansible Contributors.

Triggering tests

Members of the Team OpenShift Ansible Contributors can trigger test jobs by adding a comment containing /ok-to-test. For a full list of bot commands refer to the Bot Command Help.

Fedora tests

There are a set of tests that run on Fedora infrastructure. They are started automatically with every pull request.

They are implemented using the PAPR framework.

To re-run tests, write a comment containing only bot, retest this please.

Triggering merge

After a PR is properly reviewed and all test are passing, it can be tagged for merge by a member of the Team OpenShift Ansible Contributors by writing a comment containing /lgtm (looks good to me) anywhere in the comment body.

Tagging a Pull Request with /lgtm puts it in an automated merge queue. The @openshift-ci-robot monitors the queue and merges PRs that pass all of the required tests.

Only members of the Team OpenShift Ansible Committers can perform manual merges.

Useful links