With fixed overlay and division by zero fixed #358
Conversation
|
Looking good, thanks! Please add an example sketch that demonstrates how to use this and some documentation to the README. Maybe an animated GIF for the README? |
| @@ -42,6 +42,8 @@ | |||
|
|
|||
| #include "OLEDDisplay.h" | |||
|
|
|||
| #include <stdlib.h> | |||
There was a problem hiding this comment.
What do you need this one for?
There was a problem hiding this comment.
Sorry, there’s a war in Ukraine and my Ukrainian home has been destroyed by russian nazi so I cannot check. I suppose, vscode added it automatically for some call. Could you check it please. It’s easy - just comment it out and try to compile
There was a problem hiding this comment.
Hi!
Maybe we could return to this, could we? What should I do? Add an example and that's all?
There was a problem hiding this comment.
Thanks for coming back to this. If you could address my feedback I'd certainly appreciate it.
There was a problem hiding this comment.
gimme some time pls, I cannot get arduion working yet. looks like they changed something
Resolves #356:
3 methods added to the API:
void setFixedOverlay(FixedOverlayCallback fixedOverlayCallback)to set fixed overlay drawing foo.void setFixedOverlayFrames(const FrameCallback* fixedOverlayFramesList, int noOverlayFramesCount)to set the list of frames on which this fixed overlay will be drawn (by specifying frames callbacks, which could be useful during list changes).void setFixedOverlayFrames(int* fixedOverlayFramesList, int noOverlayFramesCount)to set the list of frames on which this fixed overlay will be drawn (by specifying frames numbers)Usage example:
FrameCallback frames[] = { frame1, frame2, frame3, frame4, frame5}; int framesCount = 5; ... ui.setFixedOverlay(someOverlayFoo); ui.setFixedOverlayFrames((const FrameCallback[]){frame2, frame3, frame5}, 3); // or ui.setFixedOverlayFrames((const uint8_t[]){1, 2, 4}, 3);