-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design/#202 메인 화면 디자인 변경 #203
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
Feat/#198: 채널 보드 삭제 기능 추가
pp449
approved these changes
Oct 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UI 가 훨씬 예뻐졌네요!
boardbar 의 경우 현재 board 형식이 아닌 새로 만들어서 사용해야할거 같아요.
Feat/#197 소개 페이지 제작 및 인증상태에 따른 메인 페이지 변경
Feat: 점수별로 등수 정렬
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤠 개요
💫 설명
헤더의 디자인과 채널 CircleBar의 디자인을 변경했어요.
또, 최상단에 LeagueHub 채널 Circle을 추가했는데 해당 채널을 누르면 어떻게 BoardBar를 바꿀지 의논을 해야할 것 같아요. 지금 Boardbar가 채널을 누르면 해당 ChannelLink로 API 요청을 보낸 후 응답 값으로 바꾸는데 LeagueHub 채널 Circle은 ChannelLink가 없어서 어떻게 할지 고민을 해야할 것 같아요.
채널 Bar의 컨텐츠가 많으면 스크롤 할 수 있도록 변경했어요.
BoardBar의 경우 아직 merge되지 않은 작업이 있어서 merge된 후 작업을 진행할게요.
📷 스크린샷 (Optional)