Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace type of notification_type field with type NotificationType in v4 #7384

Open
1 task done
ryaplots opened this issue Nov 15, 2024 · 0 comments
Open
1 task done

Replace type of notification_type field with type NotificationType in v4 #7384

ryaplots opened this issue Nov 15, 2024 · 0 comments
Labels
bump/major Needs new major version for release

Comments

@ryaplots
Copy link
Contributor

Summary

Start using the NotificationType type everywhere in the backend, including for the notification_type field starting v4

Current Situation

We have a NotificationType type which we can't use in v3 for the notification_type because this would be a breaking API change. So we currently use strings (the enum converted to string).

Desired Situation

Use the NotificationType type across the backend.

Code of Conduct
@ryaplots ryaplots added bump/major Needs new major version for release needs/triage We still need to triage this labels Nov 15, 2024
@ryaplots ryaplots changed the title Replace notification_type field type with type NotificationType in v4 Replace type of notification_type field with type NotificationType in v4 Nov 15, 2024
@KrishnaIyer KrishnaIyer removed the needs/triage We still need to triage this label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bump/major Needs new major version for release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@KrishnaIyer @ryaplots