-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normalized message pre processor not using the json schema #7382
Comments
@peter-quandify thanks for reporting, we're fixing this. |
This is deployed to all clusters and the warnings are gone. Please feel free to comment if not solved and we'll take a look. |
@peter-quandify: Which TTSS (TTN) Cluster are you testing on? |
@KrishnaIyer I'm on EU1, the error is still present when I click on Live data in the application. Not on live data for that specific device. |
@peter-quandify: we've deployed an update to The Things Stack Sandbox |
@KrishnaIyer still the same error message |
We have made yet another update and we don't see these warning logs on our side. Can you check? |
Summary
The json schema for the normalized uplink is located in the device-library. It is currently expanding but the message preprocessor is located in the lorawan-stack and does not use the schema supplied in the device-library for validation. Instead it uses a custom go code to validate.
This causes the validators to be out of sync and currently the stack validator is missing quite a few fields.
If only validation is needed in this function, then a library like this could do the trick
https://github.com/kaptinlin/jsonschema
Steps to Reproduce
Current Result
Generates an error for each field it does not recognize
Expected Result
Should accept everything that the device-library schema accepts
Relevant Logs
No response
URL
No response
Deployment
The Things Stack Community Edition
The Things Stack Version
No response
Client Name and Version
No response
Other Information
No response
Proposed Fix
No response
Contributing
Validation
Code of Conduct
The text was updated successfully, but these errors were encountered: