Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't trigger start animation when opening in new tab (CTRL + Click) #53

Open
duncanbla974 opened this issue Nov 7, 2023 · 6 comments

Comments

@duncanbla974
Copy link

I did see this issue, but it has been closed and the problem is still here.
Seems like the ctrlKey didn't work for all of us.
Is there any other workaround ?

@tomcru
Copy link

tomcru commented Nov 10, 2023

same happening here 👋
I think this is an issue because of Mac, and it using event.metaKey not ctrlKey?

Since this is taking a long while to fix and PRs are not getting merged, I've created Holy Loader as an alternative.

@iFlyinq
Copy link

iFlyinq commented Nov 20, 2023

Nice work!

@dlibis
Copy link

dlibis commented Jan 31, 2024

i have this issue occurring on macOS, when using cmd+click. the loader seems "stuck".

im using latest nextjs-toploader version: 1.6.4

@TheSGJ
Copy link
Owner

TheSGJ commented Feb 2, 2024

i have this issue occurring on macOS, when using cmd+click. the loader seems "stuck".

im using latest nextjs-toploader version: 1.6.4

Can you try using the latest version: 1.6.5, and can you tell if the loader works when using cmd + click on macOs now on version 1.6.5 or not.

@rodrigocipriani
Copy link

I've created this PR and now it's working good on my MAC

#67

@dlibis
Copy link

dlibis commented Feb 12, 2024

i have this issue occurring on macOS, when using cmd+click. the loader seems "stuck".
im using latest nextjs-toploader version: 1.6.4

Can you try using the latest version: 1.6.5, and can you tell if the loader works when using cmd + click on macOs now on version 1.6.5 or not.

yes, it works well now, good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants