Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Names not found in all commands #54

Open
TarEcthelion opened this issue May 15, 2020 · 4 comments
Open

Names not found in all commands #54

TarEcthelion opened this issue May 15, 2020 · 4 comments
Labels
bug Something isn't working

Comments

@TarEcthelion
Copy link

Currently there appears to be a bug parsing/addressing some names (ones with spaces it seems) in some commands (Damage and Remove for example)

Duplication
!omni add enemy 'War Boss' AC:40 HP:300/300 Init:{1d20+10}
!damage 'War Boss' 5
!omni remove enemy 'War Boss'

@TheCraiggers
Copy link
Owner

Well crap. That does indeed look to be a bug. Is this currently affecting your game, or was this just during testing?

@TheCraiggers TheCraiggers added the bug Something isn't working label May 18, 2020
@TarEcthelion
Copy link
Author

Testing; I was learning what it was capable of and playing with the examples.

Your choice to use a dedicated data channel works to my advantage here though, I was able to remove the data manually there. And as long as I keep the name(s) simple it's ok. I've never been a big JS guy, and I've never played with "promises" but I started looking... ;-) Just haven't found the cause yet.

Great work overall though... super impressed. Looking forward to seeing it live and grow, happy to help.

@TheCraiggers
Copy link
Owner

Hah, I've never been a big JS guy either. And promises were alien to me before I started this project. In fact, I started this in order to learn modern JS. Mostly what I've learned is that I kinda dislike it. Another contributor is working on migrating the codebase to TypeScript though, which might help some of my annoyances, so I'm trying to withhold judgement until then. =)

@mirkoRainer
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants