Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module causes a failing dev/build #30

Open
J-Pielage opened this issue May 19, 2021 · 2 comments
Open

Module causes a failing dev/build #30

J-Pielage opened this issue May 19, 2021 · 2 comments

Comments

@J-Pielage
Copy link

Hi,

I recently tried to update a 4.5.1 project to a newer version (4.7.3@stable) but the module caused a building failure.
I noticed a warming about an array to string conversion inside the CookieGroup file on lines 147 - 149:

$cookie = CookieDescription::create(array( 'ConfigName' => $cookieName, 'Title' => $cookieName, **'Provider' => $providerLabel, 'Purpose' => _t("CookieConsent_{$providerName}.{$cookieName}_Purpose", "$cookieName"), 'Expiry' => _t("CookieConsent_{$providerName}.{$cookieName}_Expiry", 'Session')** 150 ));

The same message also occurs on this line:
DB::alteration_message(sprintf('Cookie "%s" created and added to group "%s"', $cookieName, $groupName), 'created');

@TheBnl
Copy link
Owner

TheBnl commented Jun 10, 2021

Thanks for bringing this up, so far I haven't noticed the error myself.
While doing the update did the cookie-concent package update as well?
It could possibly be that the classnames have changed between versions to make it compatible with the PSR-4 standard.

for example:
Broarm\CookieConsent\CookieGroup
was changed to:
Broarm\CookieConsent\Model\CookieGroup

So maybe it is an issue with your cookie configuration?

@J-Pielage
Copy link
Author

@TheBnl Sorry for my very late response, yes I did upgrade the cookie-consent package.
I first had dev-master installed on 4.5.1. and then re-installed so it picked the latest released version.

On new projects the package does work though, so perhaps the switch between dev-master and latest release causes some issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants