Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI allows to merge things with Clippy warnings #119

Closed
TimJentzsch opened this issue Sep 29, 2024 · 3 comments
Closed

CI allows to merge things with Clippy warnings #119

TimJentzsch opened this issue Sep 29, 2024 · 3 comments
Labels
A-CI Related to CI and GitHub Actions C-Bug A bug in the program

Comments

@TimJentzsch
Copy link
Collaborator

Really not sure what's going on here...

Some dead code warnings only seem to appear on main and not in the PRs.
For example, right now we have a CI run failing on main, but it obviously passed the PR CI.

Interestingly, I also didn't get this warning emitted locally in VS Code until I changed back to main, so maybe it's not just a CI thing?

@TimJentzsch TimJentzsch added A-CI Related to CI and GitHub Actions C-Bug A bug in the program labels Sep 29, 2024
@BD103
Copy link
Member

BD103 commented Sep 29, 2024

Looks like the regression was introduced with #103. My guess is that the branch wasn't updated from main, or the cache was broken somehow.

Either way, this specific error will be fixed by #120. I'll purge the cache, and we'll see if this comes back up in the future.

@BD103
Copy link
Member

BD103 commented Sep 29, 2024

Cache has been purged. For future reference, I used this snippet to do so:

for i in $(gh cache list --json id --jq '.[].id'); do
    gh cache delete $i
done

@BD103
Copy link
Member

BD103 commented Oct 4, 2024

There have been 3 PRs merged since Clippy failed on 5cd2719, and all of them passed (with 80c81b6 as the latest). I'm going to close this, assuming it has been fixed.

@BD103 BD103 closed this as completed Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CI Related to CI and GitHub Actions C-Bug A bug in the program
Projects
None yet
Development

No branches or pull requests

2 participants