Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DecimalSliderOptionBuilder#enablePercentMode returns void instead of self #32

Open
The-Fireplace opened this issue Oct 2, 2021 · 0 comments
Open

DecimalSliderOptionBuilder#enablePercentMode returns void instead of self #32

The-Fireplace opened this issue Oct 2, 2021 · 0 comments
Labels
api enhancement New feature or request
Milestone
7.0.0

Comments

@The-Fireplace
Copy link
Member

The-Fireplace commented Oct 2, 2021 •
edited
Loading

Describe the problem
The slider returns void, which means options can't be chained like they are for all the other options.
@The-Fireplace The-Fireplace added the bug Something isn't working label Oct 2, 2021
@The-Fireplace The-Fireplace added this to the 7.0.0 milestone Oct 2, 2021
@The-Fireplace The-Fireplace added api enhancement New feature or request and removed bug Something isn't working labels Oct 2, 2021
@The-Fireplace The-Fireplace changed the title DecimalSliderOptionBuilder#enablePercentMode returns void DecimalSliderOptionBuilder#enablePercentMode returns void instead of self Oct 2, 2021
The-Fireplace added a commit that referenced this issue May 11, 2022
@The-Fireplace
Update DecimalSliderOptionBuilder's enablePercentMode to return self …
c23db56 
…for easy method chaining

Close #32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api enhancement New feature or request
Projects
None yet
Milestone
7.0.0
Development

No branches or pull requests
1 participant
@The-Fireplace