Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.5.3.2] Skyroot Milk Bucket oredict registration incorrect (fix included) #136

Open
luke-bravenboer opened this issue Jun 2, 2021 · 0 comments

Comments

@luke-bravenboer
Copy link

Version
Minecraft: 1.12.2
Forge: 14.23.5.2847
Aether: 1.12.2-v1.5.3.2


Skyroot Buckets of milk are not actually being added to the 'milkBucket'/'listAllmilk' oreDicts as intended, but there are four empty skyroot buckets being added to these oreDicts instead:

image

The cause of the issue is because the Skyroot milk bucket uses the metadata value '4', and the code that's registering these oreDict entries is erroneously using this value for the item quantity parameter instead of the meta, as you can see here:
https://github.com/Gilded-Games/The-Aether-Archived/blame/4421ae961f37f433e5a2a7c51a8254f8152b24ac/src/main/java/com/gildedgames/the_aether/dictionary/AetherDictionary.java#L66

Adding a "1, " between the two parameters @ AetherDictionary.java, lines 66/67, will fix the issue:

register("milkBucket", new ItemStack(ItemsAether.skyroot_bucket, 1, EnumSkyrootBucketType.Milk.getMeta()));
register("milkBucket", new ItemStack(ItemsAether.skyroot_bucket, 1, EnumSkyrootBucketType.Milk.getMeta()));

(And for anyone else currently experiencing the issue and looking for a workaround, here's a crafttweaker script to fix it in the meantime)

oreDict.milkBucket.remove(<aether_legacy:skyroot_bucket>*4);
oreDict.listAllmilk.remove(<aether_legacy:skyroot_bucket>*4);
oreDict.milkBucket.add(<aether_legacy:skyroot_bucket:4>);
oreDict.listAllmilk.add(<aether_legacy:skyroot_bucket:4>);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant