Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions in footer not working #85

Closed
anze3db opened this issue Jul 5, 2024 · 2 comments
Closed

Actions in footer not working #85

anze3db opened this issue Jul 5, 2024 · 2 comments

Comments

@anze3db
Copy link

anze3db commented Jul 5, 2024

I have noticed that actions in the footer no longer work by clicking them or using keyboard shortcuts (C^t, C^s, etc).

The BINDINGS defined in the CommandBuilder class no longer propagate to the parent Trogon class, where the handlers are defined (e.g., action_focus_command_tree).

Moving the BINDINGS to the Trogon class fixes the problem for me. Moving the handlers down to the CommandBuilder does as well, but I'm not sure which solution is better. Could this be an underlying issue with Textual?

I'm happy to open a PR and move the BINDINGS, just let me know if this is an ok solution.

@daneah
Copy link
Collaborator

daneah commented Aug 14, 2024

Is this potentially a duplicate of #82 ?

@anze3db
Copy link
Author

anze3db commented Aug 14, 2024

Ah, yes. Looks like a duplicate. Closing this one, thanks!

@anze3db anze3db closed this as completed Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants