Add a minimum value for TEXTUAL_FPS (_get_environ_int was extended with new functionality) and set the FPS to 60 if you set the environment value to 0. #5176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you don't, Textual will crash in src/textual/screen.py (zero division). Making it set the delay to 0 when TEXTUAL_FPS is also 0 caused the application to stop updating, and caused huge load on the CPU.
|
Thanks. Closing in favor of #5192 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5165.
This pull request adds a minimum value for TEXTUAL_FPS by updating the
_get_environ_intfunction with 2 new optional keyword parameters, and sets the TEXTUAL_FPS value to 60 if you try setting it to 0 (so as to avoid zero division errors in src/textual/screen.py).A new constant is introduced:
TEXTUAL_FPS_DEFAULT, which, as the name suggests, holds the default value for the FPS in case the environment variable is not set or is set to something that's not an integer.Please review the following checklist.