Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devtools doesn't work in spin-loops #661

Closed
willmcgugan opened this issue Aug 10, 2022 · 3 comments
Closed

Devtools doesn't work in spin-loops #661

willmcgugan opened this issue Aug 10, 2022 · 3 comments
Labels
enhancement New feature or request Task

Comments

@willmcgugan
Copy link
Collaborator

If the application code is in a spin-loop and not awaiting, then devtools will not receive any logs.

This makes complete sense due to the nature of cooperative multitasking.

I suspect the fix may be to run the websocket client in a thread so that it can run independently of the async loop.

@darrenburns
Copy link
Member

I suspect the fix may be to run the websocket client in a thread so that it can run independently of the async loop.

The better fix is to never write any infinite loops 😜

@davep davep added Task enhancement New feature or request labels Jan 11, 2023
@willmcgugan
Copy link
Collaborator Author

This doesn't seem much of a problem in practice. Closing for now.

Copy link

Don't forget to star the repository!

Follow @textualizeio for Textual updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Task
Projects
None yet
Development

No branches or pull requests

3 participants