Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "escape to dismiss" optional for maximised widgets #4949

Closed
darrenburns opened this issue Aug 28, 2024 · 2 comments · Fixed by #4951
Closed

Make "escape to dismiss" optional for maximised widgets #4949

darrenburns opened this issue Aug 28, 2024 · 2 comments · Fixed by #4951

Comments

@darrenburns
Copy link
Member

This will allow users to use a custom keybinding for maximising/minimising, and address the issue of "escape" potentially conflicting with other widgets bindings in maximised mode.

This could be passed in as an argument to the maximise action or method. (escape_to_dismiss=False/True)

@willmcgugan
Copy link
Collaborator

I'm thinking this should be a classvar constant on Screen. You probably know in advance if you want the escape_to_dismiss behavior

Copy link

Don't forget to star the repository!

Follow @textualizeio for Textual updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants