Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce Textual test suite runtime #4919

Closed
darrenburns opened this issue Aug 22, 2024 · 6 comments
Closed

Reduce Textual test suite runtime #4919

darrenburns opened this issue Aug 22, 2024 · 6 comments

Comments

@darrenburns
Copy link
Member

I think there are a few easy wins in here. This is from a run that took 33s total:

image
@darrenburns darrenburns changed the title Reduce test suite runtime Reduce Textual test suite runtime Aug 22, 2024
@willmcgugan
Copy link
Collaborator

I assume that's on CI? That top test took .46s locally.

Do you think we can get the xdist working on CI? Does it even have more than 1 core?

@darrenburns
Copy link
Member Author

Nope, it's locally. If I run it without xdist it takes 2.5 seconds. With xdist as part of the full test suite the results are pretty consistent for me (tried again and got 4.98s).

For reference: pytest --dist=loadgroup -n 16 --durations 25

@willmcgugan
Copy link
Collaborator

I get different results. I suspect the timings are obfuscated by the concurrency. Not all tests will get the same level of concurrency.

Screenshot 2024-08-22 at 11 09 15

@darrenburns
Copy link
Member Author

It's not concurrency because it's consistent for me even without xdist 😢 Must just be down to the different CPUs. Do you want to close this issue or review some of the tests that appear consistently here at some point?

@willmcgugan
Copy link
Collaborator

Keep it for a reference. But it doesn't seem a high priority. With the xdist, I still find the tests super zippy.

BTW I tweaked that slow test in the help panel PR. It was excessive.

Copy link

Don't forget to star the repository!

Follow @textualizeio for Textual updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants