-
Notifications
You must be signed in to change notification settings - Fork 814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce Textual test suite runtime #4919
Comments
I assume that's on CI? That top test took .46s locally. Do you think we can get the xdist working on CI? Does it even have more than 1 core? |
Nope, it's locally. If I run it without xdist it takes 2.5 seconds. With xdist as part of the full test suite the results are pretty consistent for me (tried again and got 4.98s). For reference: |
It's not concurrency because it's consistent for me even without xdist 😢 Must just be down to the different CPUs. Do you want to close this issue or review some of the tests that appear consistently here at some point? |
Keep it for a reference. But it doesn't seem a high priority. With the xdist, I still find the tests super zippy. BTW I tweaked that slow test in the help panel PR. It was excessive. |
Don't forget to star the repository! Follow @textualizeio for Textual updates. |
I think there are a few easy wins in here. This is from a run that took 33s total:
The text was updated successfully, but these errors were encountered: