-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
self test problems #4871
Comments
Can you paste the full output? There should be tracebacks. The failed snapshots will also produce an html file, that shows the before and after. Do you have that? |
Thank you for forcing me to take a closer look at this.
and I think two of the failing ones are because no treesitter support module is installed.
I'll attach the log output. I'm not comfortable with uploading the snapshot html file because it contains quite a lot of information about the system it's running on. Can you explain how to interpret it? |
It looks like the snapshots are broken because the following directory is missing: https://github.com/Textualize/textual/tree/main/tests/snapshot_tests/__snapshots__/test_snapshots |
Hm, the directory exists in the build/test environment (not in the environment where I looked at the html output though).
Is there some SVG support needed that I might be missing? |
It doesn't need to load the SVGs per se. It just compares them byte-wise to see if they have changed. Have you installed the dev dependancies? There was a change to pytest-textual-snapshot recently. |
Oh, that was it - I still had 0.4.0 of that (see first post). With 1.0.0 it's much better.
Details:
Some of these are because I don't have textual-dev installed, some because of the missing So this ticket is now reduced to: thank you for your support, and please add the examples needed by the tests to the pypi source distfile. |
I'm packaging textual for pkgsrc, using the pypi distfile. I usually try to run self tests on upgrades and sometimes report problems when I find them. The numbers for textual are discouraging:
That's with Python 3.12.5 on NetBSD/amd64 10.99.11 and the following modules installed:
The test summary is:
A couple are easy, some example files seem to be missing from the pypi distfile.
Most (all?) snapshot test look broken.
Let me know if I missed some dependencies or if there's another easy fix.
The text was updated successfully, but these errors were encountered: