Textual leaves Kitty terminal broken

[ihabunek]

Running any Textual app in a Kitty terminal will leave it not fully functional.

Most obviously, less does not work, pressing down does not make text scroll. I used less some_long_file.txt to test.

To reproduce, run any textual app like this one:

from textual.app import App
from textual.widgets import Label


class ReproApp(App):
    def compose(self):
        yield Label("hello world")


if __name__ == "__main__":
    app = ReproApp()
    app.run()

Exit with Ctrl+C. Terminal is now broken. Running reset fixes the terminal.

Textual Diagnostics

Versions

Name	Value
Textual	0.72.0
Rich	13.7.1

Python

Name	Value
Version	3.12.4
Implementation	CPython
Compiler	GCC 14.1.1 20240607 (Red Hat 14.1.1-5)
Executable	/home/ihabunek/.virtualenvs/pgtui/bin/python

Operating System

Name	Value
System	Linux
Release	6.9.5-200.fc40.x86_64
Version	#1 SMP PREEMPT_DYNAMIC Sun Jun 16 15:47:09 UTC 2024

Terminal

Name	Value
Terminal Application	Kitty
TERM	xterm-kitty
COLORTERM	truecolor
FORCE_COLOR	Not set
NO_COLOR	Not set

Rich Console options

Name	Value
size	width=91, height=48
legacy_windows	False
min_width	1
max_width	91
is_terminal	False
encoding	utf-8
max_height	48
justify	None
overflow	None
no_wrap	False
highlight	None
markup	None
height	None

[github-actions]

We found the following entries in the FAQ which you may find helpful:

• Why doesn't Textual look good on macOS?
• Why doesn't Textual support ANSI themes?

Feel free to close this issue if you found an answer in the FAQ. Otherwise, please give us a little time to review.

This is an automated reply, generated by FAQtory

[TomJGooding]

After running a few quick tests I suspect this may be related to the Kitty key protocol support added in #4631.

From https://sw.kovidgoyal.net/kitty/keyboard-protocol/:

Emit the escape sequence CSI < u at application exit if using the main screen or just before leaving alternate screen mode if using the alternate screen [emphasis mine]

Perhaps the fix is as simple as changing the order here?

textual/src/textual/drivers/linux_driver.py

Lines 339 to 346 in 0272c97

	# Alt screen false, show cursor
	self.write("\x1b[?1049l")
	self.write("\x1b[?25h")
	self.write("\x1b[?1004l") # Disable FocusIn/FocusOut.
	self.write(
	"\x1b[<u"
	) # Disable https://sw.kovidgoyal.net/kitty/keyboard-protocol/
	self.flush()

[github-actions]

Don't forget to star the repository!

Follow @textualizeio for Textual updates.