Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memray's test suite deadlocks with Textual 0.65.2 #4634

Closed
godlygeek opened this issue Jun 10, 2024 · 3 comments · Fixed by #4635
Closed

Memray's test suite deadlocks with Textual 0.65.2 #4634

godlygeek opened this issue Jun 10, 2024 · 3 comments · Fixed by #4635

Comments

@godlygeek
Copy link

godlygeek commented Jun 10, 2024

Memray's test suite deadlocks after Textual 0.65.2 (and specifically, I've bisected the deadlock to 7cfa1a6).

This minimal reproducer deadlocks:

import asyncio

from textual.app import App
from textual.containers import Horizontal
from textual.widgets import Footer
from textual.widgets import Tree


class TreeApp(App[None]):
    def compose(self):
        yield Horizontal(Tree("Dune"))
        yield Footer()


app = TreeApp()

async def run_test():
    async with app.run_test():
        pass

asyncio.run(run_test())

Removing the yield Footer() line causes it to no longer deadlock, as does changing the yield Horizontal(Tree("Dune")) to yield Tree("Dune")

textual diagnose output:

# Textual Diagnostics

## Versions

| Name    | Value  |
|---------|--------|
| Textual | 0.65.2 |
| Rich    | 13.7.1 |

## Python

| Name           | Value                                                            |
|----------------|------------------------------------------------------------------|
| Version        | 3.11.9                                                           |
| Implementation | CPython                                                          |
| Compiler       | GCC 11.2.1 20220127 (Red Hat 11.2.1-9)                           |
| Executable     | /home/mwoznisk/.pyenv/versions/3.11/envs/memray-3.11/bin/python3 |

## Operating System

| Name    | Value                               |
|---------|-------------------------------------|
| System  | Linux                               |
| Release | 5.15.153.1-microsoft-standard-WSL2  |
| Version | #1 SMP Fri Mar 29 23:14:13 UTC 2024 |

## Terminal

| Name                 | Value           |
|----------------------|-----------------|
| Terminal Application | tmux (3.4)      |
| TERM                 | screen-256color |
| COLORTERM            | *Not set*       |
| FORCE_COLOR          | *Not set*       |
| NO_COLOR             | *Not set*       |

## Rich Console options

| Name           | Value                |
|----------------|----------------------|
| size           | width=274, height=65 |
| legacy_windows | False                |
| min_width      | 1                    |
| max_width      | 274                  |
| is_terminal    | True                 |
| encoding       | utf-8                |
| max_height     | 65                   |
| justify        | None                 |
| overflow       | None                 |
| no_wrap        | False                |
| highlight      | None                 |
| markup         | None                 |
| height         | None                 |
Copy link

Thank you for your issue. Give us a little time to review it.

PS. You might want to check the FAQ if you haven't done so already.

This is an automated reply, generated by FAQtory

@willmcgugan
Copy link
Collaborator

Thanks. Will have a fix for the next version.

Copy link

Don't forget to star the repository!

Follow @textualizeio for Textual updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants