Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextArea theme improvements #4072

Closed
darrenburns opened this issue Jan 29, 2024 · 1 comment
Closed

TextArea theme improvements #4072

darrenburns opened this issue Jan 29, 2024 · 1 comment
Assignees

Comments

@darrenburns
Copy link
Member

darrenburns commented Jan 29, 2024

Since the default behaviour of TextArea has changed to be more general purpose text editing instead of code editing, we can make the DX of themes nicer.

Yielding a plain TextArea should result in a text area which fits nicely with the default Textual theme system.

If you use a TextAreaTheme, and unfilled attributes on that theme will fallback to sensible Textual defaults. We'll add some component styles to cover these fallbacks too.

This PR will also include hiding the cursor when the TextArea loses focus.

Estimating around 1.5 days work for this, including testing.

@darrenburns darrenburns self-assigned this Jan 29, 2024
Copy link

Don't forget to star the repository!

Follow @textualizeio for Textual updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant