Awaiting the mount of many widgets may break the app #4022
Assignees
Labels
Comments
rodrigogiraoserrao
added
bug
|
Seems to be stack related. If you increase the stack size it can handle 500 widgets. Simpler MRE: from textual.app import App
from textual.widgets import Label
# import sys
# sys.setrecursionlimit(10**6)
class LabelApp(App[None]):
async def on_mount(self):
for _ in range(500):
await self.mount(Label(";)"))
if __name__ == "__main__":
LabelApp().run()Suggest we try to get a failed stack trace, and seem if we can make it less deep. I'm also wondering if there is something significant about mounting widgets from the mount handler, which feels like an odd thing to do, but should be possible. Update: it also only occurs if you await the mounts. |
|
It looks like this was introduced in https://github.com/Textualize/textual/pull/3065/files. Specifically the change from |
|
Don't forget to star the repository! Follow @textualizeio for Textual updates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If you mount many widgets in succession with
mountand await their mount, your app may break.Even if using
mount_allworks just fine.In the example below, if I use
mount_allto mount 500 labels, Textual doesn't even bat an eye.If I use
mounton a loop 500 times, the app breaks and doesn't even clean up properly.The exact number may depend on your machine.
(Seems like it may be the fact that
AwaitMountcreates a task whenever it is awaited, so that's 500 tasks formountvs a single task formount_all.)Screen.Recording.2024-01-15.at.11.53.28.mov
Code:
The text was updated successfully, but these errors were encountered: