Command Palette duplicate ID on input kill (meta: OptionList clearing bug)

[davep]

At the moment, this issue is the opposite of an MRE, but is instead a reminder to make some time to try and produce one.

While riffing with a current pet project, I've found that it's possible to get the command palette to crash with DuplicateID: Attempt made to add options with duplicate IDs -- this cropped up a few times during development, but I thought we had it nailed.

There is no exact recipe at the moment, but I have found this evening that when I can recreate it, the steps tend to be:

• Type something that matches a handful or more commands
• Hit Ctrl+a Ctrl+k

If the wind is in the right direction you'll be left with an empty Input but will still have commands in the results list:

that is the main problem; for sure. For some reason the results haven't cleared down. After that, if you type something more, you'll get the DuplicateID.

My initial suspicion would be that something is going wrong with CommandPalette._input.

The first job here though is to try and narrow this down to a simple bit of code to recreate it (that's easy enough, it should just be a simple application with a command provider that has lots of hits), and a recipe to follow to get the error to happen on demand.

[TomJGooding]

This is probably unrelated to this error, but there are possibly some issues with OptionList validation:

• Bug with validate_highlighted after empty OptionList? #3560

[davep]

While working on a pet project, I've managed to recreate the DuplicateID issue at will, in a context other than with the command palette, and it does seem to be down to a wee bug in OptionList. Frustratingly it's proving impossible to create the issue in an isolated MRE, but the cause is very obvious in context so I suspect it's affected by how busy the message queues are.

The upshot of it seems to be this: if you try and clear and reload options for an OptionList that has no size, the list of known IDs doesn't get cleared down while other things are cleared down. I suspect the fix would be to either add a call to OptionList._clear_content_tracking to OptionList.clear_options, or to change OptionList._refresh_content_tracking so that the call to OptionList._clear_content_tracking happens before the test for self.size.width.

It's that test for size that seems to be kicking in in my current application; and I suspect this will explain why this is sometimes, but not always, seen with the command palette: there are times where it doesn't have size yet.

[davep]

As I've just run into this again a couple of times this morning in an app I'm testing, and as I think there's an easy win to be had if my assessment of the cause is correct, tagging @willmcgugan for triage.

[davep]

I'm almost positive that this has been resolved by the changes @rodrigogiraoserrao made to OptionList and/or by #4103.

[rodrigogiraoserrao]

I'm almost positive that this has been resolved by the changes @rodrigogiraoserrao made to OptionList and/or by #4103.

The original issue comment mentions a keybinding combo that leaves the command palette with no input but with some commands still showing.
Even if we fixed the duplicate ID error, neither my work on OptionList nor your linked PR solve that, right?

[davep]

I suspect that will have been down to happenstance of how and when the exception occurred; moreover it wasn't an exact set of instructions for recreation of the problem, more just recording acts that happened around the time of the problem happening.

That's not to say this issue should be closed, but I'm pretty confident it's now handled.

[davep]

I've given this a bit of a blast with the project that originally tickled the problem in November last year. After a pretty comprehensive attempt to recreate the problem I'm utterly failing (and this is a project that can have a lot of commands drop into the command palette -- I even quickly added command discovery support to overload it as much as possible without a hint of a problem).

Given the deeper dive I did while on holiday in December and given the subsequent fix to that particular problem, I feel confident in closing this as resolved by the further work done on OptionList.

[github-actions]

Don't forget to star the repository!

Follow @textualizeio for Textual updates.