-
Notifications
You must be signed in to change notification settings - Fork 815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App crashing with AttributeError: 'LoadingIndicator' object has no attribute '_start_time
#3600
Comments
This is fixed and will be in the next release, which should be pretty soon 🙂 |
Thanks for the really quick response! Is it already on the current Unfortunately, I don't see anything related in https://github.com/Textualize/textual/blob/41cadfcbf10858ad4afc6c99b52b17cac1b58fbb/CHANGELOG.md |
Yes, it's already in Edit: Updating the changelog here - #3601 |
Going to close this as I'm fairly certain it's resolved - if I'm wrong, don't hesitate to re-open. Thanks! |
Don't forget to star the repository! Follow @textualizeio for Textual updates. |
Overview
Consider the example below.
While spamming F1 and F2 keys really fast (in fact, so quickly that my fingers hurt 😄 ), app could be crashed.
I managed to trigger it in such a small example (but it's quite hard to do), but in a real, more complicated application
where we use a similar
solution, it's much easier to get the same error. I have the impression that it depends on the number of registered
watchers. Reading the callstack, it looks like the reason is that the Loading Indicator was not mounted even though it
should have been.
This is a bug report, so please don't ask me why I'm doing this way. I use public interface and documented
methods. The main goal is to use watch and give it an asynchronous method. (we use this in the implementation of our
own
DynamicLabel
widget, which can react to changes on its own (without lots of self.watch calls, we can just useyield DynamicLabel and pass a callback to it), which I previously wrote about here)
if anyone is interested, the source code of DynamicLabel looks like this, but that's not in scope of this bug report:
I think this is related to and have the impression that there is some bug hidden in the reactivity, because we observed
some app freezing also. I personally think it's also related to #3065, because we observe issues while bumping the textual version from 0.35.1 to 0.36.0.
The minimal example causing crash, I talk about:
Show
It crashes with such an error message:
Show
Video
I know that it's not easy to cause this crash, because you need to have nimble fingers, so I'm posting a video to prove
it:
Show
Screencast.from.10-27-2023.10.38.24.AM.webm
Textual diagnose
Show
Textual Diagnostics
Versions
Python
Operating System
167942497222.04~4a8cde1 SMP PREEMPT_DYNAMIC Tue MTerminal
Rich Console options
The text was updated successfully, but these errors were encountered: