Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rich styles computation for dom nodes doesn't take text-opacity into account #3413

Closed
rodrigogiraoserrao opened this issue Sep 27, 2023 · 2 comments
Closed

Rich styles computation for dom nodes doesn't take text-opacity into account #3413

rodrigogiraoserrao opened this issue Sep 27, 2023 · 2 comments
Assignees
@rodrigogiraoserrao
Labels
bug Something isn't working

Comments

@rodrigogiraoserrao
Copy link
Contributor

rodrigogiraoserrao commented Sep 27, 2023 •
edited
Loading

DOMNode.rich_style does not take into account the text opacity when computing the foreground colour.

This will likely fix Textual#3342, which in turn will likely fix Textual#3304.
@rodrigogiraoserrao rodrigogiraoserrao added the bug Something isn't working label Sep 27, 2023
@rodrigogiraoserrao rodrigogiraoserrao self-assigned this Sep 27, 2023
rodrigogiraoserrao added a commit that referenced this issue Sep 27, 2023
@rodrigogiraoserrao
Test rich styles use text opacity.
6da722d 
This fixes #3413.
@rodrigogiraoserrao rodrigogiraoserrao mentioned this issue Sep 27, 2023
Closed
rodrigogiraoserrao added a commit that referenced this issue Sep 27, 2023
@rodrigogiraoserrao
Snapshot test to keep tabs on opacity.
de6a479 
This snapshot will be used to make sure that the opacity is being taken into account when rendering widgets. This shows that some of the issues in #3304 and #3413.
@rodrigogiraoserrao rodrigogiraoserrao mentioned this issue Feb 8, 2024
Closed
@willmcgugan
Copy link
Collaborator

Fixed in main. The issue was limited to component styles.

@github-actions GitHub Actions
Copy link

Don't forget to star the repository!

Follow @textualizeio for Textual updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rodrigogiraoserrao rodrigogiraoserrao

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issues around component classes / (text) opacity Textualize/textual
2 participants
@willmcgugan @rodrigogiraoserrao