Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command Palette shows intermediate frames #3277

Closed
willmcgugan opened this issue Sep 11, 2023 · 2 comments · Fixed by #3424
Closed

Command Palette shows intermediate frames #3277

willmcgugan opened this issue Sep 11, 2023 · 2 comments · Fixed by #3424
Assignees
@davep
Labels
enhancement New feature or request Task

Comments

@willmcgugan
Copy link
Collaborator

The command palette show an intermediate frame before showing the results.

It may be hard to see in this video, but the first character produces a frame were the list is present, but there is no content. I think we should be able to suppress showing the list when no results have been retrieved.

Screen.Recording.2023-09-11.at.13.57.05.mov
@willmcgugan willmcgugan added the enhancement New feature or request label Sep 11, 2023
@davep
Copy link
Contributor

davep commented Sep 11, 2023

I think we should be able to suppress showing the list when no results have been retrieved.

Should be, although we also need to take into account that we do want to show the list before results are received at some point, so that it can be shown that we're busy (there's pretty much already logic for that so hopefully it'll just be an extra step/check).

@davep davep added the Task label Sep 11, 2023
davep added a commit to davep/textual that referenced this issue Sep 28, 2023
@davep
Only show the command palette command list when it's needed
f339cb5 
Rather than open the command palette the moment we start looking for hits,
only show it when a hit comes in, or when we need to say that no matches
were found.

Fixes Textualize#3277.
@davep davep mentioned this issue Sep 28, 2023
Merged
@davep davep linked a pull request Sep 28, 2023 that will close this issue
Command palette lazy command list show #3424
Merged
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Don't forget to star the repository!

Follow @textualizeio for Textual updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davep davep

Labels
enhancement New feature or request Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Command palette lazy command list show davep/textual
2 participants
@davep @willmcgugan