Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up keys.py and unify key representations/versions #1927

Closed
rodrigogiraoserrao opened this issue Mar 2, 2023 · 3 comments
Closed

Clean up keys.py and unify key representations/versions #1927

rodrigogiraoserrao opened this issue Mar 2, 2023 · 3 comments
Labels

Comments

@rodrigogiraoserrao
Copy link
Contributor

rodrigogiraoserrao commented Mar 2, 2023

The file keys.py contains some important constants and utility functions that are a bit hard to work with.
In my opinion, that is because we have not created a straightforward system to identify keys, their display forms, the names by which they can be referred, the corresponding characters, etc.
(Of course, this is not made easy by the fact that the type of pretty much all of these things is str...)

Some documentation would also be helpful.

I am confident I can tidy this up, but I'm adding this issue to the backlog so that we can tackle this when we are ready for that.

This is a follow-up to #1926 (and related issues).

@darrenburns
Copy link
Member

Related to work @davep is doing now.

@willmcgugan
Copy link
Collaborator

Keys are messy. Not sure we can do much about it now. But at least from the dev's POV it seems simple enough.

Copy link

Don't forget to star the repository!

Follow @textualizeio for Textual updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants