Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent naming between link-hover-* and scrollbar-*-hover CSS styles #1530

Closed
rodrigogiraoserrao opened this issue Jan 9, 2023 · 2 comments · Fixed by #3736
Closed

Inconsistent naming between link-hover-* and scrollbar-*-hover CSS styles #1530

rodrigogiraoserrao opened this issue Jan 9, 2023 · 2 comments · Fixed by #3736
Assignees
@rodrigogiraoserrao
Labels
Task

Comments

@rodrigogiraoserrao
Copy link
Contributor

The naming of the link-hover-* rules is inconsistent with that of scrollbar-*-hover.

The link rules have the modifier first:

  • link-hover-background
  • link-hover-color
  • link-hover-style

The scrollbar-* rules have the modifiers second:

  • scrollbar-background-active
  • scrollbar-background-hover
  • scrollbar-color-active
  • scrollbar-color-hover

My proposal is to rename link-hover-* to link-*-hover.
@rodrigogiraoserrao rodrigogiraoserrao changed the title Inconsistent naming between link-hover-* and scrollbar-*-hover Inconsistent naming between link-hover-* and scrollbar-*-hover CSS styles Jan 9, 2023
@davep davep added the Task label Jan 10, 2023
@Textualize Textualize deleted a comment from github-actions bot Oct 5, 2023
@willmcgugan
Copy link
Collaborator

Let's do this while we are in zerover. Don't forget the breaking change in the CHANGELOG...

@rodrigogiraoserrao rodrigogiraoserrao self-assigned this Nov 22, 2023
@rodrigogiraoserrao rodrigogiraoserrao linked a pull request Nov 27, 2023 that will close this issue
Rename link-hover-* rules to link-*-hover. #3736
Merged
@rodrigogiraoserrao rodrigogiraoserrao mentioned this issue Nov 27, 2023
Merged
@github-actions GitHub Actions
Copy link

Don't forget to star the repository!

Follow @textualizeio for Textual updates.

This was referenced Jul 18, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rodrigogiraoserrao rodrigogiraoserrao

Labels
Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename link-hover-* rules to link-*-hover. Textualize/textual
3 participants
@davep @willmcgugan @rodrigogiraoserrao