Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Binding descriptions to change #1410

Closed
antoniovazquezblanco opened this issue Dec 20, 2022 · 5 comments
Closed

Allow Binding descriptions to change #1410

antoniovazquezblanco opened this issue Dec 20, 2022 · 5 comments

Comments

@antoniovazquezblanco
Copy link

I would love to have an interface to change binding descriptions. An example would be keybinding for a toggle featue such as dark mode. It would be nice to show a binding displaying "[t] Toggle to dark theme" and when pressed show "[t] Toggle to light theme".

I would love to implement the feature if some pointers are given. Currently learning how to use textualize.

My intuition would be to change the binding object to allow reactive objects in the binding object and change the Footer class to return a renderable instead of caching the text...

Im I on the right path?

Thank you!

@github-actions
Copy link

Thank you for your issue. Give us a little time to review it.

PS. You might want to check the FAQ if you haven't done so already.

This is an automated reply, generated by FAQtory

@willmcgugan
Copy link
Collaborator

We had planned to do something like this. Honestly not sure what the best API would be yet. Could you post some psuedo-code for your proposal?

@antoniovazquezblanco
Copy link
Author

Added a work in progrees PR to look into this:

#1412

@willmcgugan
Copy link
Collaborator

This is planned for the near future.

Copy link

Don't forget to star the repository!

Follow @textualizeio for Textual updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants