Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue-next): remove unnecessary websocket binding judge #3695

Closed

Conversation

gguoyu
Copy link
Collaborator

@gguoyu gguoyu commented Dec 28, 2023

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@gguoyu gguoyu requested a review from zealotchen0 as a code owner December 28, 2023 01:48
@github-actions github-actions bot added driver: js size: s Denotes a PR that changes 10-99 lines labels Dec 28, 2023
Copy link

hippy-service bot commented Dec 28, 2023

Hi, @gguoyu. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

Copy link

hippy-service bot commented Dec 28, 2023

After a quick scan, I have approved workflow to run.

🏷️ New commits in this PR would not be tested automatically until this pull request is reviewed by our collaborators.
🏷️ No need to worry about the status of merge_guard and [gh] pull request merge guard / merge_guard (pull_request_target) checks, once this pull request is met merge requirements, it will be automatically converted to successful status.

Copy link

hippy-service bot commented Feb 26, 2024

Pay attention 🛎️ !!
There has been no activity on this PR for 2 months, so I will label it stalled.
It will be automatically closed in 30 days if no more activity. Feel free to leave a comment if you have any questions.

@hippy-service hippy-service bot added the stale: 60d No interaction in the last 60 days label Feb 26, 2024
Copy link

hippy-service bot commented Apr 27, 2024

Sorry, closing this PR because it has stalled for over 4 months.
Feel free to reopen if this PR is still relevant, or to ping the collaborator if you have any questions.

@hippy-service hippy-service bot added the stale: closed Closed due to stale label Apr 27, 2024
@hippy-service hippy-service bot closed this Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
driver: js size: s Denotes a PR that changes 10-99 lines stale: closed Closed due to stale stale: 60d No interaction in the last 60 days
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant