Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meaning of f_min in the SpectralInformation #449

Open
jktjkt opened this issue Nov 1, 2022 · 1 comment
Open

Meaning of f_min in the SpectralInformation #449

jktjkt opened this issue Nov 1, 2022 · 1 comment

Comments

@jktjkt
Copy link
Collaborator

jktjkt commented Nov 1, 2022

Right now in the JSON format, the first carrier is placed at f_min + spacing. That's not intuitive because users would typically expect them to start at f_min as the first central frequency (or, possibly, as the lowest passband edge frequency as the docs mention the edge at some places). However, doing that in the existing legacy-JSON would lead to backward-incompatible change.

References:

@EstherLerouzic
Copy link
Collaborator

maybe change the behaviour in a 3.x release also changing f_min to f_start (agreed during coders call)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants