Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add edited and numeric uploaded time as a variable to YouTube comments #949

Open
thecashewtrader opened this issue Oct 22, 2022 · 2 comments
Labels
enhancement New feature or request youtube service, https://www.youtube.com/

Comments

@thecashewtrader
Copy link

thecashewtrader commented Oct 22, 2022

Hi, I was wondering if we could add edited or similar as a variable to a comment, and change the uploaded date return format to a number.

For context, currently the getTextualUploadDate method in YoutubeCommentsInfoItemExtractor just returns the publishedTimeText, which looks something like 1 month ago (edited).

Having a separate edited variable and a numeric uploaded time duration would allow for easier translation/localisation and use by other frontends, for example: TeamPiped/Piped#1583

@thecashewtrader thecashewtrader changed the title Add edited as a variable to YouTube comments Add edited and numeric uploaded time as a variable to YouTube comments Oct 22, 2022
@FireMasterK
Copy link
Member

We've got getUploadDate for the date/timeago, we just need a way to indicate whether comments have been edited.

@thecashewtrader
Copy link
Author

Could we just check for the string ending with (edited)? I'd have submitted a PR but idk Java and it's build system etc.

@ShareASmile ShareASmile added enhancement New feature or request youtube service, https://www.youtube.com/ labels Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request youtube service, https://www.youtube.com/
Projects
None yet
Development

No branches or pull requests

3 participants