Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add feature to download to a non default folder for issue #2285 #11637

Closed
wants to merge 9 commits into from
Closed

Add feature to download to a non default folder for issue #2285 #11637

wants to merge 9 commits into from

Conversation

Gc0rp
Copy link

@Gc0rp Gc0rp commented Oct 24, 2024 •
edited by ShareASmile
Loading

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Allows the user to select an alternative folder to download other than the default folder selected.

Before/After Screenshots/Screen Record

  • Before:
    image

  • After:
    Screenshot_20241020-103610_NewPipe Debug

Fixes the following issue(s)

Due diligence

@github-actions github-actions bot added the size/small PRs with less than 50 changed lines label Oct 24, 2024
@Gc0rp Gc0rp changed the title Added feature to download to a non default folder. Added feature to download to a non default folder for issue #2285. Oct 25, 2024
@TobiGr TobiGr added downloader Issue is related to the downloader GUI Issue is related to the graphical user interface labels Oct 27, 2024
itsaky
itsaky reviewed Oct 28, 2024
View reviewed changes
Copy link

@itsaky itsaky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure about why this new feature is needed over the existing "Ask where to download" preference (when checked, that preference allows the user to select the location for each download). But I'll leave it to the maintainers to decide whether to merge this or not.

build.gradle
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in this file are irrelevant to the purpose of this PR.

settings.gradle
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in this file are irrelevant to the purpose of this PR.

@ShareASmile ShareASmile changed the title Added feature to download to a non default folder for issue #2285. Add feature to download to a non default folder for issue #2285 Oct 28, 2024
@Stypox
Copy link
Member

Stypox commented Nov 10, 2024

Closing as the app is currently undergoing a refactor and does not accept PRs for new features, especially features that would require to rethink the design of parts of the app (e.g. the download dialog). Such redesigns should be done on the refactor branch. Thank you anyway for looking into this :-)

@Stypox Stypox closed this Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsaky itsaky itsaky left review comments

Assignees
No one assigned
Labels
downloader Issue is related to the downloader GUI Issue is related to the graphical user interface size/small PRs with less than 50 changed lines
Projects
No open projects
ANU 2024
Status: Rejected
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: Select Different Download Path in Download Dialog
4 participants
@Gc0rp @Stypox @itsaky @TobiGr