Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add null-safe SharedPreferences.getStringSafe #11629

Merged
merged 1 commit into from
Oct 27, 2024

Conversation

Two-Ai
Copy link
Contributor

@Two-Ai Two-Ai commented Oct 21, 2024

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Add null-safe alternative to SharedPreferences.getString. Guarantees the return value is non-null when the provided default value is non-null.

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@github-actions github-actions bot added the size/small PRs with less than 50 changed lines label Oct 21, 2024
@opusforlife2 opusforlife2 added the codequality Improvements to the codebase to improve the code quality label Oct 21, 2024
Copy link
Member

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. the pipelines should pass after a rebase

Null-safe alternative to SharedPreferences.getString that guarantees the return value is non-null when defValue is non-null.
Copy link

sonarcloud bot commented Oct 27, 2024

@TobiGr TobiGr merged commit 64ad05d into TeamNewPipe:dev Oct 27, 2024
6 checks passed
@Stypox Stypox mentioned this pull request Nov 17, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codequality Improvements to the codebase to improve the code quality size/small PRs with less than 50 changed lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants