Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite import and export subscriptions functionality using coroutines #11759

Open
wants to merge 8 commits into
base: refactor
Choose a base branch
from

Conversation

Isira-Seneviratne
Copy link
Member

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Implement the subscription import/export functionality using CoroutineWorker for better performance and readability of the code.
  • Make the import process cancellable (exporting usually completes too quickly to show a notification).
  • Read/write subscription data using the Kotlinx Serialization library and plugin.
  • Update WorkManager from 2.8.1 to 2.10.0 (changelog)
  • Update the compile SDK to 35 (required by WorkManager).

Before/After Screenshots/Screen Record

Export

  • Before:
Screen_recording_20241129_071419.webm

Android 6.0

  • After:
Screen_recording_20241129_064527.webm

Android 6.0

Screen_recording_20241129_064829.mp4

Android 15

Fixes the following issue(s)

  • Fixes #

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@github-actions github-actions bot added the size/giant PRs with more than 750 changed lines label Nov 29, 2024
@ShareASmile ShareASmile added dependency Issues and PRs related to dependencies rewrite Issues and PRs related to rewrite import/export feature request Issue is related to a feature in the app labels Nov 29, 2024
Copy link

sonarcloud bot commented Nov 30, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency Issues and PRs related to dependencies feature request Issue is related to a feature in the app import/export rewrite Issues and PRs related to rewrite size/giant PRs with more than 750 changed lines
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

2 participants