-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(L10n): Improve en-US translation. #410
base: main
Are you sure you want to change the base?
Conversation
swordalt
commented
Sep 11, 2024
- Fixed inconsistent wording / grammar.
- Fixed odd word choices / questionable grammar.
- Made dialogue more natural and easy to read.
- Chart uploading rules are easier to understand.
- Various small improvements.
- Much more.
I edited and improved every translation in English. - Added consistency. - Natural chart upload rules. - Fixed grammar / odd choice of words. - Others.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This review may have omissions and still needs official review to decide whether to make changes.
phira/locales/en-US/common.ftl
Outdated
warn-deny-tos-policy = Accept to use online service | ||
tos-prev-page = Back | ||
tos-next-page = Next | ||
loading_tos_policy = Loading the ToS and Privacy Policy... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your ToS may be based on whether it will exceed the frame, but this message does not.
If it references from another standard, please let devs know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do you mean by "exceed the frame"? is the text length is too long?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just guess your standard is based on text length. But if that is expected, I'll support you.
cancel = Cancel | ||
confirm = Confirm | ||
lower-bound = Lower bound | ||
upper-bound = Upper bound | ||
lower-bound = Lower-Bound |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
idk but "Lower/Upper Bound" is legal for noun.
Do you want to let it as a adjective?
@@ -2,13 +2,13 @@ | |||
label = RESPACK | |||
default = Default | |||
load-failed = Failed to load respack | |||
load-failed = Failed to load respacks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About the plural, can it be error when load multiple respacks, official?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i was confused if it meant "error when importing a respack" or "error when loading imported respacks"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it's the respack the user trying to import, so maybe "load the respack" may sound better? I'm not very sure if this is grammarly ok here