Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Clickable links in entries that can lead to other entries #34

Open
Eladkay opened this issue Jul 7, 2016 · 6 comments

Comments

@Eladkay
Copy link

Eladkay commented Jul 7, 2016

Title says it all pretty much. Maybe have some sort of character or something in the localized string to mark a link? "@link("Quaritum:ShardedSkies") { Click me }" I know I'm bad at examples but maybe this could display "Click me" and link to "Quaritum:ShardedSkies"?
Thanks!

@TehNut
Copy link
Member

TehNut commented Jul 7, 2016

The cleanest way to do this would be to move everything over to ITextComponent instead of direct strings. The problem with that would be lots of breakage. Lots.

I could provide an ITextComponent "emulator" page that functions similarly to the sound page and redirects all the strings through an ITextComponent first.

@Eladkay
Copy link
Author

Eladkay commented Jul 8, 2016

ITextComponents will be great because they can do other things. (TextComponentTranslation, TextComponentScore, etc) I'd support a full move to ITextComponent but for now an "emulator" page would work.

@maxanier
Copy link

ITextComponents would be awesome.
Currently I'm using a "PageHolder"/Wrapper that displays any page, but also renders links (to other entries or a website) on the right side of the book GUI. That works fine, but is not as intuitive and good looking as a "in-text" link

@Da-Technomancer
Copy link
Contributor

Technically, you don't need changes to the built in Page to accomplish this. You could write your own Page class that you use instead which uses ITextComponent instead of strings, as there is nothing (that I can see) that mandates you have to use strings at all.

@TehNut TehNut closed this as completed Sep 24, 2017
@Eladkay
Copy link
Author

Eladkay commented Sep 24, 2017

/shrug

@TehNut
Copy link
Member

TehNut commented Sep 24, 2017

I... Didn't actually mean to close this one. I don't remember checking the box...

@TehNut TehNut reopened this Sep 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants